Freezes when entering URL about nyxt HOT 14 CLOSED

I think it's due to the call to input->queries that fetches search engine suggestions in prompter:filter-postprocessor. Maybe it's possible to make it more efficient but, regardless, there should be (1) a mechanism that only triggers it given that a certain minimum of characters has been inserted and (2) an upper bound of time to wait for the return values of input->queries given that the internet connection may be slow.

from nyxt.

I think the issue mentioned in pull request #2998 is also at work here. I've been using the development build compiled over sbcl on Debian 12 as well as Fedora 38; & have the exact same problem.

from nyxt.

@wvstolzing I don't think that's related.

Could one of you test the command set-url with the following patch applied (buffer.lisp)?

 (define-class new-url-or-search-source (prompter:source)
   ((prompter:name "New URL or search query")
-   (prompter:filter-preprocessor
-    (lambda (suggestions source input)
-      (declare (ignore suggestions source))
-      (input->queries input
-                      :check-dns-p nil
-                      :engine-completion-p nil)))
    (prompter:filter nil)
-   (prompter:filter-postprocessor
-    (lambda (suggestions source input)
-      (declare (ignore suggestions source))
-      (input->queries input
-                      :check-dns-p t
-                      :engine-completion-p t)))
    (prompter:actions-on-return #'buffer-load*))
   (:export-class-name-p t)
   (:documentation "This prompter source tries to \"do the right thing\" to

If the issue is gone, then it's due to input->queries as I've pointed out and #2998 is unrelated.

It's hard for me to reproduce the issue you're facing. Theoretically, throttling the network bandwidth could show it.

from nyxt.

I, too, have this issue. I have commented out the lines you specified in buffer.lisp and ran set-url, but the lagging still persists. Sometimes, if I type too quickly, then the entire application freezes and I have to force quit. I'm on Debian 13 (Trixie/sid) and using Nyxt 3.9.0 (Flatpak).

from nyxt.

Thank you for your reports, we will investigate!

from nyxt.

I am having the same issue.

from nyxt.

@dimitar-petrov do you have a recipe to reproduce it? I'm still unable to reproduce it.

from nyxt.

I'm just updating that I do not have this particular problem on the arch version of Nyxt, but I did experience it on Debian using the Flatpak release.

from nyxt.

@apsinthium that could indicate that it is related to the renderer since the version of WebKitGTK on Arch and Flatpak differ.

from nyxt.

Not sure if at all helpful or relevant, but I tried to make a screen capture of a typical attempt to 'open url' under Nyxt: https://youtu.be/4jiZm0nJ_Ko

I'm trying to hit <C-l>; then type lemmy.ml. At the start I make a typo; by the time I correct it, the browser has taken me to the search.atlas.engineer page for the mis-typed bit of text.

from nyxt.

@wvstolzing thanks for the recording. Unfortunately, I can't reproduce it.

The issue you face seems related to the network speed. Did you try my suggestion above?

from nyxt.

this also happens to me, but specially when there are more than 4 tabs open

from nyxt.

the same here. unable to open even one tab

from nyxt.

This issue is a duplicate of #2134.

from nyxt.