Git Product home page Git Product logo

Comments (6)

richardkall avatar richardkall commented on March 28, 2024 1

Thanks for replying and sorry for not checking this in graphql-js first.

I ended up moving the validation to the User model (Mongoose) and throwing any validation errors in the resolve function for the mutation. I could then also remove my custom Email scalar and just use the String scalar. Less files! :)

from apollo-server.

helfer avatar helfer commented on March 28, 2024

Hi @richardkall, could you do me a favor and verify that the behavior is different if you use just graphql-js on its own? If I remember correctly, graphql-js doesn't use parseLiteral on variables, because variables are already parsed as JSON. If you want to do validation, I think your only choice is to do so inside the resolve functions.

from apollo-server.

kokjinsam avatar kokjinsam commented on March 28, 2024

@helfer , I copied and pasted the Date example from apollo docs and it didn't work. As stated above, __parseLiteral is not being called.

from apollo-server.

helfer avatar helfer commented on March 28, 2024

@sammkj: As I stated above, I think that's how graphql-js works.

See also:
graphql/graphql-js#187

from apollo-server.

kokjinsam avatar kokjinsam commented on March 28, 2024

Ah I see. Thanks for the reference!

from apollo-server.

stubailo avatar stubailo commented on March 28, 2024

@richardkall can't you use _parseValue for this? That's the equivalent of _parseLiteral for variables..

from apollo-server.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.