aefeinstein / gathererscraper Goto Github PK

For cards like Dimir Charm "Watermark" is listed. That should be scraped and added to the patch.

Remove the overwrite / append option. All json files should just reflect what is currently loaded in the program.

\n vs. \r\n
Currently it uses \r\n

Hello,

I was wondering if there were a reason behind the current json format for the patches ?

I want to start working on adding multilingual support to the patches so that I can start doing the same for MTG Familiar. But I was puzzled when I saw the current json format.

If I do a commit both on GathererScraper and MTG Familiar to change the json format to make it human readable, would you accept it?

A rules change occurred which isn't reflected in the database. This should be fixed.

1. Converted mana cost

Remember when I said that the characteristics of the face that's up are all that matter? That wasn't quite accurate. Under the new rules, the converted mana cost of the back face of a DFC is based on the mana cost of the front face. (Previously, because the back faces lacked mana costs, their converted mana costs were all 0.) The one exception is if something is a copy of the back face of a DFC, its converted mana cost is 0. So If I control Insidious Mist, it has no mana cost, but its converted mana cost is 4. If I then put a copy of Insidious Mist onto the battlefield, that copy's converted mana cost is 0.

Because I previously couldn't change the patch format without crashing Familiar, color identity calculation was done in the app. This should be moved into Scraper and added as a new field in the patch.

Card names are available in different languages. GathererScraper should download this information and build it into the patches.
The available languages are:

• Chinese Simplified
• Chinese Traditional
• French
• German
• Italian
• Japanese
• Korean
• Portuguese (Brazil)
• Russian
• Spanish

PCH, PC2, CNS, CN2, ARS. Use the ones in the digest file, fix the ones in the expansion file

Also scrape these, and encode them as base 64, I guess

https://gatherer.wizards.com/Handlers/Image.ashx?type=symbol&set=1E&size=large&rarity=R

Not an exhaustive list, but Unglued cards use a symbol notation that starts with a lowercase o:
http://gatherer.wizards.com/Pages/Search/Default.aspx?action=advanced&text=+[oct:]
This should be converted to use the standard bracket notation during scraping