Comments (4)
Aaah, it seems that it is React that puts defaultProps in actual props as early as possible, so there are here from the very beginning (when React.createElement is called):
https://github.com/facebook/react/blob/master/src/isomorphic/classic/element/ReactElement.js#L233
Could we consider getting rid of them by hand? For example check at some point if component has defaultProps and if it has, remove all of such values by hand from actual props object?
from enzyme-to-json.
Hi!
Thanks for raising the issue, that's an interesting one. I agree that A
's snapshots shouldn't render B
's internals, my only concern is to check how Enzyme wrappers work. If shallow(<A />).find('B').props()
returns firstProps
and secondProps
, there's no way I can exclude secondProps
from the snapshot as I'm only relying on Enzyme wrappers, not React internals, and it might be an Enzyme bug as I wouldn't expect props()
to return default props anyway.
I'll have a look when I have time.
from enzyme-to-json.
I am up for tinkering myself and sending PR, if it's possible to provide fix. Just wanted to ask if you really consider it a bug.
from enzyme-to-json.
Hmm that's not good, I'll have look at fixing this.
from enzyme-to-json.
Related Issues (20)
- render() returns null for <script> tag HOT 2
- Deep mode includes ForwardRef HOT 6
- Component created using React.memo appears as "Component" in snapshot HOT 5
- Missing displayName for styled-component 4.x HOT 1
- Add @types/enzyme as a dependency HOT 1
- Memo Component as a prop renders as <UNDEFINED /> in snapshot HOT 1
- 3.3.5: TypeError: Cannot convert a Symbol value to a string HOT 1
- mount Fragment with new style (<>...</>) return null HOT 2
- Looking for maintainers HOT 2
- 3.4.1 error -- TypeError: Cannot read property '$$typeof' of undefined HOT 4
- moving from 3.4.0 to 3.4.1 breaks snapshots HOT 3
- Cannot find type definition file for 'cheerio'. HOT 1
- Timestamp key in mock function lead to fail snapshot test HOT 1
- Node crashes when using toJson HOT 7
- ForwardRef included in deep mount
- Allow depth option when serializing mounted wrappers
- JSON changes with each run - React 17 and ReactDOM.createPortal()
- High severity vulnerability found in lodash 4.17.15 HOT 6
- cannot find module 'cheerio' from 'node_modules/enzyme/build/utils.js
- Critical Security Issues Report
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from enzyme-to-json.