Default props visible in shallow snapshot about enzyme-to-json HOT 4 CLOSED

Aaah, it seems that it is React that puts defaultProps in actual props as early as possible, so there are here from the very beginning (when React.createElement is called):

https://github.com/facebook/react/blob/master/src/isomorphic/classic/element/ReactElement.js#L233

Could we consider getting rid of them by hand? For example check at some point if component has defaultProps and if it has, remove all of such values by hand from actual props object?

from enzyme-to-json.

Hi!

Thanks for raising the issue, that's an interesting one. I agree that A's snapshots shouldn't render B's internals, my only concern is to check how Enzyme wrappers work. If shallow(<A />).find('B').props() returns firstProps and secondProps, there's no way I can exclude secondProps from the snapshot as I'm only relying on Enzyme wrappers, not React internals, and it might be an Enzyme bug as I wouldn't expect props() to return default props anyway.

I'll have a look when I have time.

from enzyme-to-json.

I am up for tinkering myself and sending PR, if it's possible to provide fix. Just wanted to ask if you really consider it a bug.

from enzyme-to-json.

Hmm that's not good, I'll have look at fixing this.

from enzyme-to-json.