Comments (4)
Hi @dgovil ,
This is considered a valid graph (i.e. unique naming within the "namespace" / graph level) so it seems it's more a problem with logic for code generation and vote to fix that. There are existing unique name matching issues before so adding @niklasharrysson in.
from materialx.
That's good to know, thanks. I edited the issue title accordingly.
from materialx.
Hey @niklasharrysson ,
I looked at the code a bit and it's the same issue we've discussed before -- that of lack of appropriate ShaderGraph
context when dealing with nodegraph
s . i.e. all ShaderNode
s are in the same ShaderGraph
. So the node name map will encounter the same node name more than once -- resulting in the symptom encountered here
// We have a node downstream
ShaderNode* downstream = getNode(downstreamNode->getName());
if (downstream && connectingElement)
{
ShaderInput* input = downstream->getInput(connectingElement->getName());
if (!input)
{
throw ExceptionShaderGenError("Could not find an input named '" + connectingElement->getName() +
"' on downstream node '" + downstream->getName() + "'");
}
input->makeConnection(output);
}
getNode()
looks up by name which is not unique.
from materialx.
Hey @kwokcb , thanks for investigating. And yes, this will be resolved when we get to updating the ShaderGraph to keep all graph hierarchies.
from materialx.
Related Issues (20)
- Proposal: Migrate comment documentation to nodedef doc attributes for std libraries HOT 2
- MaterialXGraphViewer: `time_float` and `frame_float` do not have any effect HOT 3
- GLSL ShaderGen: `time_float` and `frame_float` do not have any effect HOT 6
- Proposal: MaterialX Hair BSDF
- Angle units handling
- Input node resolution failure when same-named nodes exist inside and outside a nodegraph HOT 3
- Smoothstep breaks GLSL compilation when multiple type signature nodes are used HOT 13
- generateshader cannot validate shaders with lighting
- Equivalence operator fails to handle vector string differences HOT 12
- Multiple type signature possible problem
- Graph Editor: Mouse UI action orbits camera in render view HOT 2
- Suggestion: Add command line commands for Python package
- Proposal : Provide a Functionally equivalent operator HOT 8
- Proposal: Add a simple way to strip out library content on XML write
- Add a Supported Versions table to SECURITY.md
- Set up [email protected]
- Consider adopting signed release tags HOT 1
- Consider signing release artifacts HOT 3
- Consider running Step Security on your repo
- Proposal: Add a default unit option
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from materialx.