aaronrobinsonmsft / ppdb Goto Github PK

Hello,

I'm using VS 2019. I have compiled the PPDB, created new .net core 3.1 console application project and tried to PPDBDump the pdb for that application. Unfortunately there is an exception:

./PPDBDump.exe "C:\Users\pkruk\Source\repos\NetCorePortablePdb\NetCorePortablePdb\bin\Debug\netcoreapp3.1\NetCorePortablePdb.dll"
Exception: 2 (Name 'Portable PDB', Table '-1')

It is thrown by this code in PortablePdbReader constructor:

    // Check min size and magic number: 'BJSB'
    if (_data_view.size() < sizeof(*header)
        || header->Magic != 0x424A5342)
    {
        throw Exception{ ErrorCode::CorruptFormat };
    }

The actual header->Magic value is 0x905A4D.

I'm attaching the NetCorePortablePdb.dll:

NetCorePortablePdb.zip

I have also tried with the same result:

• .net core 3.0 and 2.0
• use vs2017 to create pdb
• .net framework 4.8 with full and portable pdb

Create a shared library with an ISymUnmanagedReader implementation backed by the Reader static library.

We need to write portable PDBs (and embedded) in our native scenario. It would be awesome if this static lib supported that as it would save us a bunch of time

Hello,

Problem description

Streams.cpp line 366 has following assertion:

        pt.EndColumn = pt.StartColumn + colRange;
        assert(pt.EndColumn < 0x10000);
        assert(pt.StartLine == pt.EndLine || pt.StartColumn < pt.EndColumn); // line 366

The condition evaluates to false for following code:

        static string GetPipeName() => IsWindows
        ? "a"
        : "b";

Here, the sequence points represents conditional operator, so start line is < end line, but start column is > end column. For example (9,40) - (11,14).

Fix

I assume the intention was to check if StartColumn < EndColumn only if they are in the same line:

        assert(pt.StartLine == pt.EndLine ? pt.StartColumn < pt.EndColumn : true);

By the way, can StartColumn == EndColumn (for one-line sequence points)?

See spec for Document Name Blob.

See #7 for added assert.

The index type for the CustomDebugInformation table is a coded index defined in ECMA-335. This type of index was never implemented and instead hard-coded to always be 2 bytes at:

The fix is to add proper support for coded indices.

Hi there, thank you for publishing this, it looks incredibly useful and well written!

One question that arises in deciding whether to take a dependency on PPDB is whether the tool has been rigorously tested in a production use-case (e.g. as part of a Microsoft service or product), or if it's more of a personal project that has only been tested in the context of your personal needs? Any info you could share would be highly appreciated!