skinsrestorer / skinsrestorerx Goto Github PK

View Code? Open in Web Editor NEW

505.0 12.0 169.0 7.16 MB

The most popular skin plugin for Minecraft

Home Page: https://skinsrestorer.net

License: GNU General Public License v3.0

Java 99.97% Kotlin 0.02% Shell 0.01%

minecraft minecraft-plugin sponge-plugin bungeecord-plugin spigotmc velocity-plugin spigot-plugin

skinsrestorerx's Introduction

SkinsRestorer

This is the development repository for SkinsRestorer (Minecraft plugin).

Restoring offline mode skins & changing skins for Bukkit/Spigot/Paper, BungeeCord/Waterfall, Sponge, CatServer and Velocity servers.

🔭 Compatibility

WE DO NOT SUPPORT FORGE / FABRIC

Java 17+ (Get Adoptium)
Minecraft 1.8.0 - 1.20.4

Implementation:

Proxy: BungeeCord (Waterfall) & Velocity
Backend: Bukkit (Spigot, Paper, Purpur, etc.) & SpongeVanilla

🔗 Links

📥 How to install? / Installation / Setup

You can read on our website how to install SkinsRestorer. Make sure to follow all steps before reporting issues!

🌈 Community

Feel free to join our Discord community server:

🏗️ SkinsRestorer API

You can find instructions on how to use the SkinsRestorer API on our website.

👪 Authors

See Contributors for a list of people that have supported this project by contributing.

📜 License

SkinsRestorer is licensed under GNU General Public License v3.0. Please see LICENSE for more info.

skinsrestorerx's People

Contributors

Stargazers

Watchers

Forkers

xknat asvaidas drtshock stefatorus aaron1011 logics4 benwoodworth brainstone winde03 andrewaubury crypnotic dyanakiev theblobinc anonymousdr eudiaminecraft voidpointer0x00 tominous aljaxus gust09 moker59 itzvgcgpmo apachezy gitcodergc stashenko samcz elitenetworkmc yg1203108068 spcbar-networks videogamesmash12 evanlegamer eoghanmc22 sqwwqw5 jojo1542 nkd3v madis0 xxdark uikota zontreck teamkun fireentity toffikk celestialkitsune mclive alfredmr meowray sandtechnology alkanex-xyz luoyiwei3 capablezbd vmajster kuohsuanlo xuwznln bakalexis sonicno1 camotoy analitycynet rosiecube uranosolar tildearrow rhycraft lengmou233 dum4g th3tr0ller slamdunx fyumemcbe daveq96 kwadratowa magicsweet-dev aevydevs cbroad sumidafax pjrcodes jalumu benfiratkaya iaiao cometwei benjamonsrl gearmagicss mannpro9575 theamazingzote yanknkt kwlentmt liuet2001 2b2ttanxiu bobodka untuned deathgod7 huyvu1832 mcdoeswhat keefyvfx edgarg4m3r notyusta rize-woomy meowcraftmc thebadpandy bogz6969 sicopata7 rikudosanin olegsha yakiee

skinsrestorerx's Issues

Add new message strings on demand instead of having to remove msgs.yml

on long terms. we want to fix the issue where you need to remove the msgs.yml to update the help config and the help player so that we can update these new commands.

is this possible with for example a version in the msgs.yml to force a update?
this is for long terms...

Unknown host exception (getmeproxy.com) should warn to check firewall

We need to add more exception info and not java errors that they will report all the time:

https://pastebin.com/hsf6UXQQ

add /sr defaultskins add output

add /sr defaultskins add output to forexample
player <%player> has been added as a default skin

this is working for disabledskins so just a fast copy paste haha

default messages.yml language set

What doesn't work (or what feature do you request)?

make it easy to switch language using our own default provided set

skins without perms for bungee

a lot i mean a lot of request are that they want to have to do commands without a permissions system or to even do permissions because some fail.

possible to make the skinswithout work in bungee? 💯

"Please wait a minute before requesting that skin again. (Rate Limited)"

What doesn't work (or what feature do you request)?

"/skin" command gives "Please wait a minute before requesting that skin again. (Rate Limited)"
and in server console I get "Switching to proxy to get skin property." and "Proxy list is empty. Getting one." After that nothing happens.

How to reproduce the bug? (if a bug)

By giving that /skin command

What version of SkinsRestorer do you use?

13.2

[Discussion] Should Sponge support be removed in following versions?

There is nobody to support it and users are already reporting issues with it.

Leave your opinion below

Default Skins option is broken on BungeeCord

What doesn't work (or what feature do you request)?

default skins does not work well for bungee

How to reproduce the bug? (if a bug)

i used 13.1.3 on spigot with defaultskins it did work
but some how on bungee it does not seem to work

What version of SkinsRestorer do you use?

13.1.3

move skingui msg lines to locale.java

move all skingui message lines to locale to make it more appealing to use for foreign servers

Don't send locale messages if the string is empty

someone requested me to remove the sr line.
told him this is not possible unless you self code

can you make a if sr_line = " " inside the locale it will skip this line on display

[request = click here ]

Server crashes when the plugin can't find a proxy

additional default skins option to skip premium users

add a additional config option for default skins to skip premium users to set a default skin (so there are no more stave. this should better on big networks in general)

tip: you could use the same way we detect NOT_PREMIUM

https://github.com/DoNotSpamPls/SkinsRestorerX/blob/ca2289ac838f63222ba62cb7d14cf3ae9611aab0/src/main/java/skinsrestorer/shared/utils/MojangAPI.java#L100-L106

/skin clear gives an internal error if you try it without having a skin

[19:34:12 ERROR]: null
org.bukkit.command.CommandException: Unhandled exception executing command 'skin' in plugin SkinsRestorer v13.2-SNAPSHOT
Caused by: java.lang.NullPointerException
        at skinsrestorer.bukkit.commands.SkinCommand.onCommand(SkinCommand.java:42) ~[?:?]

1.7 support in the plugin is half-working

On the protocol hack, 1.8 players can see skins, while 1.7 players can't. I suspect this is because of the format changes that 1.8 introduced.

Make plugin on async

This would allow us to optimize the methods and decrease the TPS drops

TLauncher interferes with SkinsRestorer

What doesn't work (or what feature do you request)?

SkinsRestorer's skins don't show if player is using TLauncher.

How to reproduce the bug? (if a bug)

1 - Join with TLauncher (and ely.by skins turned on) in a server with SkinsRestorer.
2 - Here you go.
This doesn't happen if ely.by skins are turned off on TLauncher's settings.

What version of SkinsRestorer do you use?

It should affect all the versions including the latest.

Replace Reflection with Abstraction

In the long term, we'd like to replace Reflection NMS with Abstraction. That way we can have cleaner code.

mysql wont work async

just tested with version logics have me (13.3-snapshot).
mysql wont connect. and on the 13.2 release it did

option for toggleing between /skin set or /skin

MY SUGGESTION !

add config option to toggle between /skin set and /skin command

Regards,
~Lazos

Some proxies are blocked from Mojang API

it does respond. but not what we want...
code 403 forbidden because some proxy's did block mojang api.
skinsrestorer must search for next one...

issue by: iKoner#0003
https://thumb.gyazo.com/thumb/1200/_122948c2ff462cc18a4ab18535615ce2-png.jpg

timeout timer is wrong

timer is giving wrong data when goign over 30seconds cooldown (only display is wrong) read this: https://www.spigotmc.org/threads/skinsrestorer.37225/page-151#post-2641449

Replace YamlConfig with Bukkit/BungeeCord's in-house methods

Because we're using YamlConfig, all comments from the config file get instantly wiped.

BungeeCord crash

What doesn't work (or what feature do you request)?

https://pastebin.com/5apw93TZ

For some reason the bungeecord log has been filled with this error, until java has been unable to do more and has shown "OutOfMemoryError GC overhead limit exceeded".

I have been using SkinRestorer for a long time and I never had problems.
I have not modified my iptables or firewall at this time

How to reproduce the bug? (if a bug)

I do not know how to reproduce it or when it happens.

What version of SkinsRestorer do you use?

13.3

catch ConnectException for checkVersion

we should put this:
https://github.com/DoNotSpamPls/SkinsRestorerX/blob/master/src/main/java/skinsrestorer/bungee/SkinsRestorer.java#L48

above this error:
https://www.spigotmc.org/threads/skinsrestorer.37225/page-156#post-2836586
to make it more clear that is just failed to check a version and did not make a crash (some don't read java because of language barrier

we might need to catch ConnectException
https://github.com/DoNotSpamPls/SkinsRestorerX/blob/master/src/main/java/skinsrestorer/bungee/SkinsRestorer.java#L46-L47

might be something we want to do with #60

/sr SkinWithoutPerm output bug

when doing /sr SkinWithoutPerm true
it will set it on 'true' in config. plz remove the ''

The plugin doesn't work on CraftBukkit

[09:26:46 ERROR]: Error occurred while enabling SkinsRestorer v13.2-SNAPSHOT (Is                                                                                                                                                                                                it up to date?)
java.lang.NullPointerException
        at skinsrestorer.bukkit.SkinsRestorer.log(SkinsRestorer.java:49) ~[?:?]
        at skinsrestorer.bukkit.SkinsRestorer.onEnable(SkinsRestorer.java:106) ~                                                                                                                                                                                               [?:?]
        at org.bukkit.plugin.java.JavaPlugin.setEnabled(JavaPlugin.java:321) ~[c                                                                                                                                                                                               raftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at org.bukkit.plugin.java.JavaPluginLoader.enablePlugin(JavaPluginLoader                                                                                                                                                                                               .java:332) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at org.bukkit.plugin.SimplePluginManager.enablePlugin(SimplePluginManage                                                                                                                                                                                               r.java:404) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at org.bukkit.craftbukkit.v1_8_R3.CraftServer.loadPlugin(CraftServer.jav                                                                                                                                                                                               a:342) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at org.bukkit.craftbukkit.v1_8_R3.CraftServer.enablePlugins(CraftServer.                                                                                                                                                                                               java:314) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.s(MinecraftServer.java:4                                                                                                                                                                                               06) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.k(MinecraftServer.java:3                                                                                                                                                                                               70) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.a(MinecraftServer.java:3                                                                                                                                                                                               25) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at net.minecraft.server.v1_8_R3.DedicatedServer.init(DedicatedServer.jav                                                                                                                                                                                               a:235) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at net.minecraft.server.v1_8_R3.MinecraftServer.run(MinecraftServer.java                                                                                                                                                                                               :504) [craftbukkit-1.8.8.jar:git-Bukkit-e1ebe52]
        at java.lang.Thread.run(Unknown Source) [?:1.8.0_151]

Detect changeskin

What doesn't work (or what feature do you request)?

Let skinsrestorer warn that it does not work well with changeskin by adding sofdepent

Plugin conflicts with FastLogin and (sometimes) AntiBotDeluxeEX

it does not change the .player file to the default skin as it should

Add a check for /skin clear if the player has a skin

Right now it will just clear the skin indefinetely.

more mysql output

we need mor output when it can't connect or for example when it's crating a new database. this way we should give owners more awareness that's its working or not since otherwise think that MySQL is not working while it's on the api part.

please add the following output:

on creating new MySQL database
an error once when it can't connect. (it does not)
an error on wrong password (if possible)

also maybe we should add a option to fallback to flatfile if it lost connection....
but that's prob a new enchanting issue :P

tasklist for skinclear

make it permission op &/or skinsrestorer.playercmds.clear
[prevent internal error when doing 2x clear]
[make the line only appear when you have the right permissions so when player does not have
skinsrestorer.playercmds.clear or op, it won't see the command in /skin (same as /sr in /skin when)]

optional:

make 2 extra lines in inlocale for these things: https://github.com/Th3Tr0LLeR/SkinsRestorer---Maro/blob/c541be72a7886dfddf601f96da27c0e667b80e04/src/skinsrestorer/bungee/commands/PlayerCommands.java#L51 (dont forget both bukkit & bungee)
1.2 make it update the new lines from the above auto update when missing (old locale)

Add a logging config option

make it possable to disable loggin (proxy default skin ect) in config

op issue with authme reloaded

this issue did appear after version 13.1.3 with the fix of:
"/skin notch disable usage of commandblocks till /restart or /deop -> /op"

Th3Tr0LLeR/SkinsRestorer---Maro#209

Give the option to use proxy.txt instead of dynamic proxy getting

Sponge Metrics don't work

Clear user's skin in /sr

Be able to use /sr clearskin (playername to clear player's skin

add debug and translate exceptions

we should make it more understandable for server owners what the error is and catch exceptions with a information log.
adding a debug config option to switch

remove DisableOnJoinSkins from default config.yml

remove the config DisableOnJoinSkins from the config.yml
and add a "//this is a hidden feature" to the source code
but keep it in the config reload module

its annoying because some dont know how to config and put random things on true

/skinsmenu in bungee

/skinsmenu in bungee would be awesome

Use Hikari for MySQL instead of Java SQL

Hikari is the de-facto standard for Java MySQL related things, with low latency and high reliability.

Add %skin as a variable

What doesn't work (or what feature do you request)?

request: add a %skin to [ADMIN_SET_SKIN = "&2You set %player's skin.";]

What doesn't work (or what feature do you request)?

we only added mvcore world dependency but we should try and support more world plugin since mvcore is not the only one used.

How to reproduce the bug? (if a bug)

just use multiworld here: https://dev.bukkit.org/projects/multiworld-v-2-0

What version of SkinsRestorer do you use?

13.2

this is it prob:
https://dev.bukkit.org/projects/multiworld-v-2-0/pages/api

MySQL tries to connect way too fast

i think we should add a timeout or something

add /sr status to bungee

woops /sr status has not been added to bungee yet

skinsrestorer / skinsrestorerx Goto Github PK

skinsrestorerx's Introduction

SkinsRestorer

🔭 Compatibility

🔗 Links

📥 How to install? / Installation / Setup

🌈 Community

🏗️ SkinsRestorer API

👪 Authors

📜 License

skinsrestorerx's People

Contributors

Stargazers

Watchers

Forkers

skinsrestorerx's Issues

What doesn't work (or what feature do you request)?

What doesn't work (or what feature do you request)?

How to reproduce the bug? (if a bug)

What version of SkinsRestorer do you use?

What doesn't work (or what feature do you request)?

How to reproduce the bug? (if a bug)

What version of SkinsRestorer do you use?

What doesn't work (or what feature do you request)?

How to reproduce the bug? (if a bug)

What version of SkinsRestorer do you use?

MY SUGGESTION !

What doesn't work (or what feature do you request)?

How to reproduce the bug? (if a bug)

What version of SkinsRestorer do you use?

What doesn't work (or what feature do you request)?

What doesn't work (or what feature do you request)?

What doesn't work (or what feature do you request)?

How to reproduce the bug? (if a bug)

What version of SkinsRestorer do you use?

Recommend Projects

Recommend Topics

Recommend Org