codechain-io / codechain Goto Github PK

Specify which transactions should force the node to reseal a block.

• none: never reseal on new transactions
• own: reseal only on a new local transaction
• ext: reseal only on a new external transaction
• all: reseal on all new transactions.

The default is own.

How to add or remove validators safely?

It's not a significant matter because the attempt fails.

Add maximum_extra_data_size field to CommonParams and reject transactions whose size exceed the maximum.

https://github.com/CodeChain-io/codechain/blob/master/spec/Block-Synchronization-Extension.md

Depends on: #1884

Todo:

• Generate snapshots periodically (10/31~)
  • Compress/decompress chunk
  • Make a state into chunks
  • Read & verify chunks and recover the state
  • Make chunk snapshot and recover property test success #1844 (~11/13)
  • Add block event listener to snapshot periodically (~11/15) #1869
    • for the tendermint (~11/19) #1874
  • Snapshot configurations
    • Set the expiration date #1875
• Update the sync extension for snapshot sync
  • Update network messages for snapshots (~11/14) #1843
  • Switch to full sync after the snapshot sync is finished #1855 (~11/15)
  • Make snapshot header importable
    • Make consensus extensions to work without parent header (~11/27) (@remagpie)
    • Make blockchain work without history (~11/15) #1862
    • Update sync extension to ignore total_score of status message (~11/19) #1864
  • Fetch snapshot header from peers (~11/15) #1862
  • Collect snapshots from peers (~11/22) #1872
• RPC to query the snapshot information (~11/22) #1873
• Test functionallity on testnet (~12/1)

Good To Have:

• Make the snapshot period configurable

Show information about version when -v or --version option is given.

Make it possible to slash deposit if double-vote is detected.

• Modify state trie
  • move state shard to shard0 state trie
  • Add metadata under top-level shard
• One shard parcel without shard validators

Dump transaction queue on shutdown and then reload it on startup.

Report the proposer if no proposal was received.

We may punish the proposer if it keeps not proposing blocks.

Currently, we use debug_assert in most cases because we check the assertions in tests and we don't want to check them again in the release binary.

But it's not sustainable. Bugs will occur for any reason. It seems better to use assert to crash early because we have a plan to add a bug tracker.

I think we need a guideline to decide when to use assert or debug_assert.

ripemd160 is the only 160 bit hash function which is secure. It is required to implement atomic swap with Bitcoin and Ethereum.

The method name connect is misleading because it just negotiates the protocol name and version on top of the already established connection.

Validators can join/leave the network.

• Make genesis block create shard
• Handle CreateShard Parcel
• Embed shard id in asset scheme address
• Specify shard id on ChangeShardState parcel
• Multiple shard parcel without validators

The same block can have different block hashes because the same block from different validators can have different set of COMMIT signatures.

We need a bug tracker like sentry.

Don't use hardcoded target value when logging.

trace!(target: "txqueue",
       "Dropping transaction without sufficient balance: {:?} ({} < {})",
       tx.hash(),
       client_account.balance,
       tx.fee
);

We need pre-defined constants for targets.

Specify the address which should be used to sign consensus messages and issue blocks.

Currently, discovery extensions share all addresses in the routing table.

Currently, extension user must call negotiate API on node_added event.
It was designed to support the extension which doesn't want to negotiate with some peers.
But until now, there are no that kinds of extensions, and it just makes the control flow complicate.
So I suggest changing the API as below.

pub trait Api: Send + Sync {
    fn send(&self, node: &NodeId, message: &[u8]);
-   fn negotiate(&self, node: &NodeId);

    fn set_timer(&self, timer: TimerToken, d: Duration) -> Result<()>;
    fn set_timer_once(&self, timer: TimerToken, d: Duration) -> Result<()>;
    fn clear_timer(&self, timer: TimerToken) -> Result<()>;

    fn send_local_message(&self, message: &Encodable);
}

pub trait Extension: Send + Sync {
    fn name(&self) -> String;
    fn need_encryption(&self) -> bool;
+   fn versions(&self) -> Vec<Version>;

    fn on_initialize(&self, api: Arc<Api>);

-   fn on_node_added(&self, _node: &NodeId) {}
+   fn on_node_added(&self, version: Version, _node: &NodeId) {}
    fn on_node_removed(&self, _node: &NodeId) {}

-   fn on_negotiated(&self, _node: &NodeId) {}
-   fn on_negotiation_allowed(&self, _node: &NodeId) {}
-   fn on_negotiation_denied(&self, _node: &NodeId) {}

    fn on_message(&self, _node: &NodeId, _message: &[u8]) {}

    fn on_timeout(&self, _timer: TimerToken) {}

    fn on_local_message(&self, _message: &[u8]) {}
}

https://github.com/kodebox-io/codechain/blob/ce5f925a087fc892ed252d02b0949ebf2237f97f/network/src/extension.rs#L68

Describe what CodeChain is.

Specify the block author (aka "coinbase") address for sending block rewards from sealed blocks.

Currently, a block can be arbitrarily large.

Add block reward to solo and solo_authority.

data field is no longer necessary once actions are added.

Currently, SetRegularKey has no effect.

AssetMint creates an Asset object and an AssetScheme object. Each field is related to one between the two, but, currently, it is confused which is related to one or not.

Current:

AssetMint {
    metadata: String,
    lock_script_hash: H256,
    parameters: Vec<Bytes>,
    amount: Option<u64>,
    registrar: Option<Address>,
    nonce: u64,
},

Proposed:

AssetMint {
    metadata: String,
    registrar: Option<Address>,
    nonce: u32,
    output: AssetMintOutput
}

struct AssetMintOutput {
    lock_script_hash: H256,
    parameters: Vec<Bytes>,
    amount: u64,
}

Currently, Travis only builds Mac OS X binary. Add Linux build.

Currently, there is no penalty for Byzantine validators. Make them deposit certain amount of CCC and slash it.

add_blocks of test client doesn't assign it now.

• Struct rename
  • Transaction -> Parcel
  • Action -> Transaction
• Parcel struct restructure
  • Transaction -> Vec
• Multiple tx in one parcel

https://gitter.zendesk.com/hc/en-us/articles/200176722-Integrations